Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1675193002: Rename 'composed tree' to 'flat tree' in the layout tests. (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename 'composed tree' to 'flat tree' in the layout tests. This is a follow-up patch of r374095, renaming layout tests file names and their contents. BUG=531990 Committed: https://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0 Cr-Commit-Position: refs/heads/master@{#374267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1013 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html View 1 chunk +0 lines, -227 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt View 1 chunk +0 lines, -373 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection-expected.txt View 1 chunk +0 lines, -181 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal.html View 16 chunks +22 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-expected.txt View 20 chunks +20 lines, -20 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-shadow-reprojection.html View 6 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/flat-tree-traversal-shadow-reprojection-expected.txt View 7 chunks +7 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-composed-parent-dirty-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/getComputedStyle-flat-tree-parent-dirty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/event-dispatching.js View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/resources/shadow-dom.js View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-details-summary-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-to-younger-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-empty-shadow-element-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675193002/1
4 years, 10 months ago (2016-02-08 08:34:45 UTC) #2
hayato
PTAL
4 years, 10 months ago (2016-02-08 10:59:52 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 11:48:35 UTC) #8
tkent
lgtm. I found "composed shadow tree" in FocusNavigationScope::focusNavigationScopeOf().
4 years, 10 months ago (2016-02-08 23:23:47 UTC) #9
hayato
On 2016/02/08 23:23:47, tkent wrote: > lgtm. > > I found "composed shadow tree" in ...
4 years, 10 months ago (2016-02-09 01:55:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675193002/1
4 years, 10 months ago (2016-02-09 01:58:47 UTC) #12
kochi
lgtm
4 years, 10 months ago (2016-02-09 02:07:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 02:12:23 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 02:14:06 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c11d345c76dbf3ad45fdb45d7818f3709f551bf0
Cr-Commit-Position: refs/heads/master@{#374267}

Powered by Google App Engine
This is Rietveld 408576698