third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp - Issue 1675183006: tracing: add dump provider for malloc heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

Issue 1675183006: tracing: add dump provider for malloc heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shim_layer_linux

Patch Set: ssid review Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/heap_profiler_allocation_context_tracker.cc ('K') | « components/tracing/docs/heap_profiler_internals.md ('k') | third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

index 9a00c3437898488d7d6c368fe206c5cd6ca1df0f..d269b2935139513e1d1452d0d4f7d7aa39f788ba 100644

--- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

+++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

@@ -170,7 +170,7 @@ void PartitionAllocMemoryDumpProvider::onHeapProfilingEnabled(bool enabled)

void PartitionAllocMemoryDumpProvider::insert(void* address, size_t size, const char* typeName)

{

- base::trace_event::AllocationContext context = base::trace_event::AllocationContextTracker::GetContextSnapshot();

+ base::trace_event::AllocationContext context = base::trace_event::AllocationContextTracker::GetInstanceForCurrentThread()->GetContextSnapshot();

context.type_name = typeName;

MutexLocker locker(m_allocationRegisterMutex);

if (m_allocationRegister)