Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: src/heap/store-buffer.cc

Issue 1675163003: Filter out invalid slots in store buffer eagerly during object transition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Enable WriteBarrierObjectShiftFieldsRight test and add comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/store-buffer.h ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index acfa70cf8ecafd8a0803d4c7fd38767fff565120..3df9f6e4fa1df020bb992653047b45c206e79308 100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -63,6 +63,15 @@ void StoreBuffer::StoreBufferOverflow(Isolate* isolate) {
isolate->counters()->store_buffer_overflows()->Increment();
}
+void StoreBuffer::Remove(Address addr) {
+ InsertEntriesFromBuffer();
+ MemoryChunk* chunk = MemoryChunk::FromAddress(addr);
+ DCHECK_EQ(chunk->owner()->identity(), OLD_SPACE);
+ uintptr_t offset = addr - chunk->address();
+ DCHECK_LT(offset, static_cast<uintptr_t>(Page::kPageSize));
+ if (chunk->old_to_new_slots() == nullptr) return;
+ chunk->old_to_new_slots()->Remove(static_cast<uint32_t>(offset));
+}
#ifdef VERIFY_HEAP
void StoreBuffer::VerifyPointers(LargeObjectSpace* space) {
« no previous file with comments | « src/heap/store-buffer.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698