Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: test/cctest/test-unboxed-doubles.cc

Issue 1675163003: Filter out invalid slots in store buffer eagerly during object transition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Enable WriteBarrierObjectShiftFieldsRight test and add comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <utility> 6 #include <utility>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/compilation-cache.h" 10 #include "src/compilation-cache.h"
(...skipping 1531 matching lines...) Expand 10 before | Expand all | Expand 10 after
1542 map, 0, kData, NONE, Representation::Tagged(), any_type, FORCE_FIELD); 1542 map, 0, kData, NONE, Representation::Tagged(), any_type, FORCE_FIELD);
1543 1543
1544 if (write_barrier_kind == OLD_TO_NEW_WRITE_BARRIER) { 1544 if (write_barrier_kind == OLD_TO_NEW_WRITE_BARRIER) {
1545 TestWriteBarrier(map, new_map, 2, 1); 1545 TestWriteBarrier(map, new_map, 2, 1);
1546 } else { 1546 } else {
1547 CHECK_EQ(OLD_TO_OLD_WRITE_BARRIER, write_barrier_kind); 1547 CHECK_EQ(OLD_TO_OLD_WRITE_BARRIER, write_barrier_kind);
1548 TestIncrementalWriteBarrier(map, new_map, 2, 1); 1548 TestIncrementalWriteBarrier(map, new_map, 2, 1);
1549 } 1549 }
1550 } 1550 }
1551 1551
1552 1552 TEST(WriteBarrierObjectShiftFieldsRight) {
1553 // TODO(ishell): enable when this issue is fixed.
1554 DISABLED_TEST(WriteBarrierObjectShiftFieldsRight) {
1555 TestWriteBarrierObjectShiftFieldsRight(OLD_TO_NEW_WRITE_BARRIER); 1553 TestWriteBarrierObjectShiftFieldsRight(OLD_TO_NEW_WRITE_BARRIER);
1556 } 1554 }
1557 1555
1558 1556
1559 TEST(IncrementalWriteBarrierObjectShiftFieldsRight) { 1557 TEST(IncrementalWriteBarrierObjectShiftFieldsRight) {
1560 TestWriteBarrierObjectShiftFieldsRight(OLD_TO_OLD_WRITE_BARRIER); 1558 TestWriteBarrierObjectShiftFieldsRight(OLD_TO_OLD_WRITE_BARRIER);
1561 } 1559 }
1562 1560
1563 1561
1564 // TODO(ishell): add respective tests for property kind reconfiguring from 1562 // TODO(ishell): add respective tests for property kind reconfiguring from
1565 // accessor field to double, once accessor fields are supported by 1563 // accessor field to double, once accessor fields are supported by
1566 // Map::ReconfigureProperty(). 1564 // Map::ReconfigureProperty().
1567 1565
1568 1566
1569 // TODO(ishell): add respective tests for fast property removal case once 1567 // TODO(ishell): add respective tests for fast property removal case once
1570 // Map::ReconfigureProperty() supports that. 1568 // Map::ReconfigureProperty() supports that.
1571 1569
1572 #endif 1570 #endif
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698