mojo/shell/standalone/android/ui_application_loader_android.h - Issue 1675153002: ApplicationImpl->ShellConnection, mojom::Application->mojom::ShellClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/standalone/android/ui_application_loader_android.h

Issue 1675153002: ApplicationImpl->ShellConnection, mojom::Application->mojom::ShellClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ci2

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/shell/standalone/android/background_application_loader_unittest.cc ('k') | mojo/shell/standalone/android/ui_application_loader_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/shell/standalone/android/ui_application_loader_android.h

diff --git a/mojo/shell/standalone/android/ui_application_loader_android.h b/mojo/shell/standalone/android/ui_application_loader_android.h

index 6a8c03e2f49718f2654c8ef6d853524c3a6201bb..5f9b5e155cfe03369dccce1162004ff961731420 100644

--- a/mojo/shell/standalone/android/ui_application_loader_android.h

+++ b/mojo/shell/standalone/android/ui_application_loader_android.h

@@ -29,7 +29,7 @@ class UIApplicationLoader : public ApplicationLoader {

// ApplicationLoader overrides:

void Load(const GURL& url,

- InterfaceRequest<mojom::Application> application_request) override;

+ InterfaceRequest<mojom::ShellClient> request) override;

private:

class UILoader;

@@ -39,7 +39,7 @@ class UIApplicationLoader : public ApplicationLoader {

// TODO: having this code take a |manager| is fragile (as ApplicationManager

// isn't thread safe).

void LoadOnUIThread(const GURL& url,

- InterfaceRequest<mojom::Application> application_request);

+ InterfaceRequest<mojom::ShellClient> request);

void ShutdownOnUIThread();

scoped_ptr<ApplicationLoader> loader_;