Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3192)

Unified Diff: build/config/allocator.gni

Issue 1675143004: Allocator shim skeleton + Linux impl behind a build flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shim_exp_flag
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/allocator/allocator_shim_unittest.cc ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/allocator.gni
diff --git a/build/config/allocator.gni b/build/config/allocator.gni
index 2c908fea6791603a79cdc4e75d2d93b9bee7a07f..eb764ded5747260a66a3050d3d5b412b97c84294 100644
--- a/build/config/allocator.gni
+++ b/build/config/allocator.gni
@@ -24,5 +24,5 @@ declare_args() {
assert(use_allocator == "none" || use_allocator == "tcmalloc")
assert(!is_win || use_allocator == "none", "Tcmalloc doesn't work on Windows.")
-assert(!use_experimental_allocator_shim || is_linux,
+assert(!use_experimental_allocator_shim || is_linux || is_nacl,
Nico 2016/03/08 03:08:42 why is this needed?
Primiano Tucci (use gerrit) 2016/03/08 20:54:05 Oh that didn't really work as expected, removing i
"use_experimental_allocator_shim supported only on Linux")
« base/allocator/allocator_shim_unittest.cc ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698