Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1675103002: Roll WebGL conformance tests. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL conformance tests. BUG= TEST=webgl_conformance, webgl2_conformance TBR=kbr@chromium.org,bajones@chromium.org NOTRY=true Committed: https://crrev.com/38cf26e851dc15585565f95c8153dd1531dcd80e Cr-Commit-Position: refs/heads/master@{#374061}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 5 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675103002/1
4 years, 10 months ago (2016-02-07 18:11:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-07 19:23:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675103002/20001
4 years, 10 months ago (2016-02-07 19:37:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-07 19:41:53 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/38cf26e851dc15585565f95c8153dd1531dcd80e Cr-Commit-Position: refs/heads/master@{#374061}
4 years, 10 months ago (2016-02-07 19:43:11 UTC) #11
flackr
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1676283002/ by flackr@chromium.org. ...
4 years, 10 months ago (2016-02-08 14:17:03 UTC) #12
Zhenyao Mo
4 years, 10 months ago (2016-02-09 17:13:15 UTC) #13
Message was sent while issue was closed.
On 2016/02/08 14:17:03, flackr wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1676283002/ by mailto:flackr@chromium.org.
> 
> The reason for reverting is: Sorry, looks like this roll introduced some
> failures on Nexus 6:
>
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus...
> 
> [  FAILED  ] 
>
WebglConformance.conformance_textures_image_bitmap_tex_image_and_sub_image_2d_with_image_bitmap_rgb_rgb_unsigned_byte
> [  FAILED  ] 
>
WebglConformance.conformance_textures_image_bitmap_tex_image_and_sub_image_2d_with_image_bitmap_rgb_rgb_unsigned_short_5_6_5
> [  FAILED  ] 
>
WebglConformance.conformance_textures_image_bitmap_tex_image_and_sub_image_2d_with_image_bitmap_rgba_rgba_unsigned_byte
> [  FAILED  ] 
>
WebglConformance.conformance_textures_image_bitmap_tex_image_and_sub_image_2d_with_image_bitmap_rgba_rgba_unsigned_short_4_4_4_4
> [  FAILED  ] 
>
WebglConformance.conformance_textures_image_bitmap_tex_image_and_sub_image_2d_with_image_bitmap_rgba_rgba_unsigned_short_5_5_5_1.

Please don't revert.  We always update test expectations in such cases.

Powered by Google App Engine
This is Rietveld 408576698