Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1675053002: test parsepath (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add unit test to feed valid SVG sequences to make sure that path strings can be parsed without returning an error. Draw the output through Skia and SVG to make sure they are parsed correctly. R=fmalita@chromium.org BUG=skia:4549 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675053002 Committed: https://skia.googlesource.com/skia/+/f1d415188ffb4c34e2886c2cfceb363a148333f1

Patch Set 1 #

Patch Set 2 : add test file #

Patch Set 3 : test svg parsing more thoroughly #

Patch Set 4 : get rid of extra spaces #

Patch Set 5 : remove extra code from add_comma #

Patch Set 6 : simplify test #

Patch Set 7 : wip; parse path svg compare #

Patch Set 8 : fix parse path to match svg #

Patch Set 9 : remove typo in skpath #

Patch Set 10 : turn off easy #

Patch Set 11 : fix test formatting #

Patch Set 12 : factor out common test code #

Patch Set 13 : fix formatting #

Patch Set 14 : rebase #

Patch Set 15 : unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -23 lines) Patch
M gm/arcto.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +83 lines, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkParsePath.cpp View 1 2 3 4 5 6 7 7 chunks +26 lines, -23 lines 0 comments Download
M tests/ParsePathTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +17 lines, -0 lines 0 comments Download
A tools/random_parse_path.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +17 lines, -0 lines 0 comments Download
A tools/random_parse_path.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675053002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675053002/100001
4 years, 10 months ago (2016-02-07 03:27:30 UTC) #5
caryclark
PTAL. I scraped all of the SVG out of chrome tests but they weren't very ...
4 years, 10 months ago (2016-02-07 03:29:16 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-07 03:56:43 UTC) #8
f(malita)
lgtm
4 years, 10 months ago (2016-02-08 16:24:01 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675053002/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675053002/230001
4 years, 10 months ago (2016-02-09 17:13:00 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/106)
4 years, 10 months ago (2016-02-09 17:14:53 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675053002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675053002/250001
4 years, 10 months ago (2016-02-09 17:15:17 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/107)
4 years, 10 months ago (2016-02-09 17:17:10 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675053002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675053002/270001
4 years, 10 months ago (2016-02-09 17:26:17 UTC) #18
caryclark
Take another look if you like. This fixes a couple of bugs in Skia core ...
4 years, 10 months ago (2016-02-09 17:33:58 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 18:01:57 UTC) #23
f(malita)
lgtm++
4 years, 10 months ago (2016-02-09 18:29:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675053002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675053002/270001
4 years, 10 months ago (2016-02-09 18:29:44 UTC) #26
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 18:30:27 UTC) #28
Message was sent while issue was closed.
Committed patchset #15 (id:270001) as
https://skia.googlesource.com/skia/+/f1d415188ffb4c34e2886c2cfceb363a148333f1

Powered by Google App Engine
This is Rietveld 408576698