Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1675003002: X87: [fullcode] Change fullcode to compile finally using the token approach. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcode] Change fullcode to compile finally using the token approach. port 334d17946ccbca4e8b96c6211a3387000fe63d55 (r33780) original commit message: This change should unify handling of finally blocks in Turbofan's AstGraphBuilder and in full-code. This should enable smooth deoptimization from finally blocks. BUG= Committed: https://crrev.com/0067ed0f26c73dc1ae335b7ac3fe6abbc895bf4b Cr-Commit-Position: refs/heads/master@{#33794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +27 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-06 02:05:22 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-06 02:07:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675003002/1
4 years, 10 months ago (2016-02-06 02:10:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 18:05:19 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 18:06:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0067ed0f26c73dc1ae335b7ac3fe6abbc895bf4b
Cr-Commit-Position: refs/heads/master@{#33794}

Powered by Google App Engine
This is Rietveld 408576698