Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1674963002: Probably don't need an unused re-implementation of addAll(). :) (Closed)

Created:
4 years, 10 months ago by Bob Nystrom
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Probably don't need an unused re-implementation of addAll(). :) R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/3f3b242f398d330cfcac04b58c791653583a0a36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 10 months ago (2016-02-06 00:14:58 UTC) #2
Paul Berry
lgtm
4 years, 10 months ago (2016-02-06 15:21:06 UTC) #3
Bob Nystrom
4 years, 10 months ago (2016-02-08 23:10:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f3b242f398d330cfcac04b58c791653583a0a36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698