Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 167493002: Make sure isolate library is initialized before using isolate natives. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Make sure isolate library is initialized before using isolate natives. The compiler only adds 'startRootIsolate' if we use the dart:isolate library. === if (hasIsolateSupport()) { enqueuer.codegen.addToWorkList( isolateHelperLibrary.find(Compiler.START_ROOT_ISOLATE)); enqueuer.codegen.registerGetOfStaticFunction(main); } === However the isolate-native library requires some of the startRootIsolate elements to be resolved. Therefore we must use the dart:isolate library in the native-isolate tests. Committed: https://code.google.com/p/dart/source/detail?r=32709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M sdk/lib/_internal/lib/isolate_helper.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/compute_this_script_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
TBR.
6 years, 10 months ago (2014-02-14 19:10:26 UTC) #1
floitsch
Committed patchset #1 manually as r32709 (presubmit successful).
6 years, 10 months ago (2014-02-14 19:10:48 UTC) #2
sigurdm
6 years, 10 months ago (2014-02-17 08:25:40 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698