Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1674813002: increase subdivision for very large cubics (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

increase subdivision for very large cubics Allow 512 subdivisions for hairline cubics instead of 64 to allow very large cubics to be properly approximated with lines. R=reed@google.com BUG=339297 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1674813002 Committed: https://skia.googlesource.com/skia/+/52b64619d99325bac2f9b53c9fb0a4b7c69e442f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M gm/strokefill.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674813002/1
4 years, 10 months ago (2016-02-05 20:51:58 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-05 20:51:59 UTC) #4
reed1
lgtm
4 years, 10 months ago (2016-02-05 21:02:30 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 21:59:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/52b64619d99325bac2f9b53c9fb0a4b7c69e442f

Powered by Google App Engine
This is Rietveld 408576698