Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1674683002: Add --output-directory to stack tool buildbot step (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --output-directory to stack tool buildbot step BUG=573345 Committed: https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a Cr-Commit-Position: refs/heads/master@{#374136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
agrieve
On 2016/02/05 15:53:13, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org I think this ...
4 years, 10 months ago (2016-02-05 15:54:01 UTC) #3
jbudorick
On 2016/02/05 15:54:01, agrieve wrote: > On 2016/02/05 15:53:13, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 10 months ago (2016-02-05 15:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674683002/1
4 years, 10 months ago (2016-02-08 15:10:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 16:51:33 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a Cr-Commit-Position: refs/heads/master@{#374136}
4 years, 10 months ago (2016-02-08 16:52:30 UTC) #10
flackr
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1677193002/ by flackr@chromium.org. ...
4 years, 10 months ago (2016-02-08 19:29:19 UTC) #11
jbudorick
4 years, 10 months ago (2016-02-08 19:32:20 UTC) #12
Message was sent while issue was closed.
On 2016/02/08 19:29:19, flackr wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1677193002/ by mailto:flackr@chromium.org.
> 
> The reason for reverting is: This has is failing 'Run stack tool with logcat
> dump' step on several android bots:
>
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus...
>
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus...
> .

Why do the GPU bots still use these!? I thought we were down to fyi bots... :(

Powered by Google App Engine
This is Rietveld 408576698