Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 10 months ago by agrieve Modified:
4 years, 10 months ago Reviewers:
jbudorick CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd --output-directory to stack tool buildbot step
BUG=573345
Committed: https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a
Cr-Commit-Position: refs/heads/master@{#374136}
Patch Set 1 #
Created: 4 years, 10 months ago
Depends on Patchset: Messages
Total messages: 12 (5 generated)
Description was changed from ========== Add --output-directory to stack tool buildbot step BUG=573345 ========== to ========== Add --output-directory to stack tool buildbot step BUG=573345 ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
On 2016/02/05 15:53:13, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org I think this is the only place that needs updating. But looks like official build scripts downstream will also need updating, so need to wait for that as well.
On 2016/02/05 15:54:01, agrieve wrote: > On 2016/02/05 15:53:13, agrieve wrote: > > mailto:agrieve@chromium.org changed reviewers: > > + mailto:jbudorick@chromium.org > > I think this is the only place that needs updating. But looks like official > build scripts downstream will also need updating, so need to wait for that as > well. This lgtm, but there are very, very few bots that still use these scripts. Most of it is in infra-land. I'll send you a CL in a bit.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674683002/1
Message was sent while issue was closed.
Description was changed from ========== Add --output-directory to stack tool buildbot step BUG=573345 ========== to ========== Add --output-directory to stack tool buildbot step BUG=573345 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add --output-directory to stack tool buildbot step BUG=573345 ========== to ========== Add --output-directory to stack tool buildbot step BUG=573345 Committed: https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a Cr-Commit-Position: refs/heads/master@{#374136} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ec0616bfa85b1af5369766ee9dad95e69cfe1f7a Cr-Commit-Position: refs/heads/master@{#374136}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1677193002/ by flackr@chromium.org. The reason for reverting is: This has is failing 'Run stack tool with logcat dump' step on several android bots: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... .
Message was sent while issue was closed.
On 2016/02/08 19:29:19, flackr wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1677193002/ by mailto:flackr@chromium.org. > > The reason for reverting is: This has is failing 'Run stack tool with logcat > dump' step on several android bots: > https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... > https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus... > . Why do the GPU bots still use these!? I thought we were down to fyi bots... :( |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
