Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: src/utils/debugger/SkOverdrawMode.cpp

Issue 1674673002: Alter SkXfermode's asFragmentProcessor & asXPFactory contracts (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/gpu/SkGr.cpp ('K') | « src/gpu/SkGr.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/utils/debugger/SkOverdrawMode.cpp
diff --git a/src/utils/debugger/SkOverdrawMode.cpp b/src/utils/debugger/SkOverdrawMode.cpp
index 400e58309f0d73c327e7c79177680df4f7d307f4..895c8daf5857d03110ec351ad4897d6dde9e2acc 100644
--- a/src/utils/debugger/SkOverdrawMode.cpp
+++ b/src/utils/debugger/SkOverdrawMode.cpp
@@ -291,19 +291,12 @@ public:
SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkOverdrawXfermode)
#if SK_SUPPORT_GPU
- bool asFragmentProcessor(const GrFragmentProcessor** output,
- const GrFragmentProcessor* dst) const override {
- if (output) {
- *output = GrOverdrawFP::Create(dst);
- }
- return true;
+ const GrFragmentProcessor* asFragmentProcessor(const GrFragmentProcessor* dst) const override {
+ return GrOverdrawFP::Create(dst);
}
- bool asXPFactory(GrXPFactory** xpf) const override {
- if (xpf) {
- *xpf = GrOverdrawXPFactory::Create();
- }
- return true;
+ GrXPFactory* asXPFactory() const override {
+ return GrOverdrawXPFactory::Create();
}
#endif
« src/gpu/SkGr.cpp ('K') | « src/gpu/SkGr.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698