Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/effects/SkPixelXorXfermode.cpp

Issue 1674673002: Alter SkXfermode's asFragmentProcessor & asXPFactory contracts (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix unit test bug Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/effects/SkAvoidXfermode.cpp ('k') | src/effects/SkXfermodeImageFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkPixelXorXfermode.cpp
diff --git a/src/effects/SkPixelXorXfermode.cpp b/src/effects/SkPixelXorXfermode.cpp
index 833eecd85940f4fd6c37856d863d2edb691f04dc..7432ef132b066ca022681b8c1907a5c68e51d9f5 100644
--- a/src/effects/SkPixelXorXfermode.cpp
+++ b/src/effects/SkPixelXorXfermode.cpp
@@ -368,19 +368,13 @@ const GrXPFactory* GrPixelXorXPFactory::TestCreate(GrProcessorTestData* d) {
///////////////////////////////////////////////////////////////////////////////
-bool SkPixelXorXfermode::asFragmentProcessor(const GrFragmentProcessor** output,
- const GrFragmentProcessor* dst) const {
- if (output) {
- *output = PixelXorFP::Create(fOpColor, dst);
- }
- return true;
+const GrFragmentProcessor* SkPixelXorXfermode::getFragmentProcessorForImageFilter(
+ const GrFragmentProcessor* dst) const {
+ return PixelXorFP::Create(fOpColor, dst);
}
-bool SkPixelXorXfermode::asXPFactory(GrXPFactory** xpf) const {
- if (xpf) {
- *xpf = GrPixelXorXPFactory::Create(fOpColor);
- }
- return true;
+GrXPFactory* SkPixelXorXfermode::asXPFactory() const {
+ return GrPixelXorXPFactory::Create(fOpColor);
}
#endif
« no previous file with comments | « src/effects/SkAvoidXfermode.cpp ('k') | src/effects/SkXfermodeImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698