Alter SkXfermode's asFragmentProcessor & asXPFactory contracts

src/gpu/SkGr.cpp

 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkGr.h"
 
@@ skipping 471 matching lines @@
             SkAutoTUnref<const GrFragmentProcessor> cfFP(
                 colorFilter->asFragmentProcessor(context));
             if (cfFP) {
                 grPaint->addColorFragmentProcessor(cfFP);
             } else {
                 return false;
             }
         }
     }
 
-    SkXfermode* mode = skPaint.getXfermode();
-    GrXPFactory* xpFactory = nullptr;
-    SkXfermode::AsXPFactory(mode, &xpFactory);
-    SkSafeUnref(grPaint->setXPFactory(xpFactory));
+    SkXfermode* xfermode = skPaint.getXfermode();
+    if (xfermode) {

[egdaniel, 2016/02/08 15:32:11]

This is the check for srcOver right? So that we keep it null on the GrPaint? If
that is the case I think we may want an assert the before this call the XPF on
GrPaint is null. Along with a comment explaining why this is here?

[robertphillips, 2016/02/08 15:54:53]

Done.

+        grPaint->setXPFactory(xfermode->asXPFactory())->unref();
+    }
 
 #ifndef SK_IGNORE_GPU_DITHER
     if (skPaint.isDither() && grPaint->numColorFragmentProcessors() > 0) {
         grPaint->addColorFragmentProcessor(GrDitherEffect::Create())->unref();
     }
 #endif
     return true;
 }
 
 bool SkPaintToGrPaint(GrContext* context, const SkPaint& skPaint, const SkMatrix& viewM,
@@ skipping 123 matching lines @@
             SkErrorInternals::SetError( kInvalidPaint_SkError,
                                         "Sorry, I don't understand the filtering "
                                         "mode you asked for.  Falling back to "
                                         "MIPMaps.");
             textureFilterMode = GrTextureParams::kMipMap_FilterMode;
             break;
 
     }
     return textureFilterMode;
 }