Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/compiler/fast-accessor-assembler.h

Issue 1674633002: Move FastAccessorAssembler from RawMachineAssembler to CodeStubAssembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
danno 2016/02/18 15:01:15 Since this class no longer uses the raw machine as
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_ 5 #ifndef V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_
6 #define V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_ 6 #define V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <vector> 9 #include <vector>
10 10
11 // Clients of this interface shouldn't depend on lots of compiler internals. 11 // Clients of this interface shouldn't depend on lots of compiler internals.
12 // Do not include anything from src/compiler here! 12 // Do not include anything from src/compiler here!
13 #include "include/v8-experimental.h" 13 #include "include/v8-experimental.h"
14 #include "src/base/macros.h" 14 #include "src/base/macros.h"
15 #include "src/base/smart-pointers.h" 15 #include "src/base/smart-pointers.h"
16 #include "src/handles.h" 16 #include "src/handles.h"
17 17
18 // For CodeStubAssembler::Label. (We cannot forward-declare inner classes.)
19 #include "src/compiler/code-stub-assembler.h"
18 20
19 namespace v8 { 21 namespace v8 {
20 namespace internal { 22 namespace internal {
21 23
22 class Code; 24 class Code;
23 class Isolate; 25 class Isolate;
24 class Zone; 26 class Zone;
25 27
26 namespace compiler { 28 namespace compiler {
27 29
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 void CheckNotZeroOrJump(ValueId value_id, LabelId label_id); 71 void CheckNotZeroOrJump(ValueId value_id, LabelId label_id);
70 72
71 // C++ callback. 73 // C++ callback.
72 ValueId Call(FunctionCallback callback, ValueId arg); 74 ValueId Call(FunctionCallback callback, ValueId arg);
73 75
74 // Assemble the code. 76 // Assemble the code.
75 MaybeHandle<Code> Build(); 77 MaybeHandle<Code> Build();
76 78
77 private: 79 private:
78 ValueId FromRaw(Node* node); 80 ValueId FromRaw(Node* node);
79 LabelId FromRaw(RawMachineLabel* label); 81 LabelId FromRaw(CodeStubAssembler::Label* label);
80 Node* FromId(ValueId value) const; 82 Node* FromId(ValueId value) const;
81 RawMachineLabel* FromId(LabelId value) const; 83 CodeStubAssembler::Label* FromId(LabelId value) const;
82 84
85 void Clear();
83 Zone* zone() { return &zone_; } 86 Zone* zone() { return &zone_; }
87 Isolate* isolate() const { return isolate_; }
84 88
85 Zone zone_; 89 Zone zone_;
86 base::SmartPointer<RawMachineAssembler> assembler_; 90 Isolate* isolate_;
91 base::SmartPointer<CodeStubAssembler> assembler_;
87 92
88 // To prevent exposing the RMA internals to the outside world, we'll map 93 // To prevent exposing the RMA internals to the outside world, we'll map
89 // Node + Label pointers integers wrapped in ValueId and LabelId instances. 94 // Node + Label pointers integers wrapped in ValueId and LabelId instances.
90 // These vectors maintain this mapping. 95 // These vectors maintain this mapping.
91 std::vector<Node*> nodes_; 96 std::vector<Node*> nodes_;
92 std::vector<RawMachineLabel*> labels_; 97 std::vector<CodeStubAssembler::Label*> labels_;
93 98
94 // Remember the current state for easy error checking. (We prefer to be 99 // Remember the current state for easy error checking. (We prefer to be
95 // strict as this class will be exposed at the API.) 100 // strict as this class will be exposed at the API.)
96 enum { kBuilding, kBuilt, kError } state_; 101 enum { kBuilding, kBuilt, kError } state_;
97 102
98 DISALLOW_COPY_AND_ASSIGN(FastAccessorAssembler); 103 DISALLOW_COPY_AND_ASSIGN(FastAccessorAssembler);
99 }; 104 };
100 105
101 } // namespace compiler 106 } // namespace compiler
102 } // namespace internal 107 } // namespace internal
103 } // namespace v8 108 } // namespace v8
104 109
105 #endif // V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_ 110 #endif // V8_COMPILER_FAST_ACCESSOR_ASSEMBLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698