Move FastAccessorAssembler from RawMachineAssembler to CodeStubAssembler.

src/compiler/code-stub-assembler.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_CODE_STUB_ASSEMBLER_H_
 #define V8_COMPILER_CODE_STUB_ASSEMBLER_H_
 
 #include <map>
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
@@ skipping 51 matching lines @@
   V(Word64Or)                                 \
   V(Word64And)                                \
   V(Word64Xor)                                \
   V(Word64Shr)                                \
   V(Word64Sar)                                \
   V(Word64Ror)                                \
   V(UintPtrGreaterThanOrEqual)
 
 class CodeStubAssembler {
  public:
+  // CodeStubAssembler for generating stubs.
   // |result_size| specifies the number of results returned by the stub.
   // TODO(rmcilroy): move result_size to the CallInterfaceDescriptor.
   CodeStubAssembler(Isolate* isolate, Zone* zone,
                     const CallInterfaceDescriptor& descriptor,
                     Code::Flags flags, const char* name,
                     size_t result_size = 1);
+
+  // CodeStubAssembler for generating JS functions.
+  CodeStubAssembler(Isolate* isolate, Zone* zone, int parameter_count,
+                    Code::Flags flags, const char* name);
+
   virtual ~CodeStubAssembler();
 
   Handle<Code> GenerateCode();
 
   class Label;
   class Variable {
    public:
     explicit Variable(CodeStubAssembler* assembler, MachineRepresentation rep);
     void Bind(Node* value);
     Node* value() const;
@@ skipping 10 matching lines @@
   // Base Assembler
   // ===========================================================================
 
   // Constants.
   Node* Int32Constant(int value);
   Node* IntPtrConstant(intptr_t value);
   Node* NumberConstant(double value);
   Node* HeapConstant(Handle<HeapObject> object);
   Node* BooleanConstant(bool value);
   Node* ExternalConstant(ExternalReference address);
+  Node* NullConstant();
+  Node* UndefinedConstant();
 
   Node* Parameter(int value);
   void Return(Node* value);
 
   void Bind(Label* label);
   void Goto(Label* label);
   void Branch(Node* condition, Label* true_label, Label* false_label);
 
   void Switch(Node* index, Label* default_label, int32_t* case_values,
               Label** case_labels, size_t case_count);
@@ skipping 61 matching lines @@
                  Node* context, Node* arg1, Node* arg2, Node* arg3, Node* arg4,
                  size_t result_size = 1);
   Node* CallStub(const CallInterfaceDescriptor& descriptor, Node* target,
                  Node* context, Node* arg1, Node* arg2, Node* arg3, Node* arg4,
                  Node* arg5, size_t result_size = 1);
 
   Node* TailCallStub(CodeStub& stub, Node** args);
   Node* TailCall(const CallInterfaceDescriptor& descriptor, Node* target,
                  Node** args, size_t result_size = 1);
 
+  // Calls w/ custom CallDescriptor. Prefer the call methods above.
+  Node* CallN(CallDescriptor* descriptor, Node* code_target, Node** args);

[danno, 2016/02/18 15:01:15]

Nit: The TailCallStub call doesn't append the "N" above despite the args list.
Which one is more consistent with the rest of the code?

+  Node* TailCallN(CallDescriptor* descriptor, Node* code_target, Node** args);
+
   // ===========================================================================
   // Macros
   // ===========================================================================
 
   // Tag and untag Smi values.
   Node* SmiTag(Node* value);
   Node* SmiUntag(Node* value);
 
   // Load a value from the root array.
   Node* LoadRoot(Heap::RootListIndex root_index);
 
   // Check a value for smi-ness
   Node* WordIsSmi(Node* a);
 
   // Load an object pointer from a buffer that isn't in the heap.
   Node* LoadBufferObject(Node* buffer, int offset);
   // Load a field from an object on the heap.
   Node* LoadObjectField(Node* object, int offset);
 
+  // Load a machine-typed value from an object on the heap, or from a native
+  // (C++) object.
+  Node* LoadObjectFieldTyped(Node* object, int offset, MachineType rep);

[danno, 2016/02/18 15:01:15]

Any reason to not combine these with the LoadObjectField method and have the
MachineType rep be a default argument with value kTagged?

+  Node* LoadNativeFieldTyped(Node* object, int offset, MachineType rep);
+
   // Load an array element from a FixedArray.
   Node* LoadFixedArrayElementSmiIndex(Node* object, Node* smi_index,
                                       int additional_offset = 0);
   Node* LoadFixedArrayElementConstantIndex(Node* object, int index);
 
  protected:
   // Protected helpers which delegate to RawMachineAssembler.
   Graph* graph();
   Isolate* isolate();
   Zone* zone();
 
   // Enables subclasses to perform operations before and after a call.
   virtual void CallPrologue();
   virtual void CallEpilogue();
 
  private:
   friend class CodeStubAssemblerTester;
 
-  Node* CallN(CallDescriptor* descriptor, Node* code_target, Node** args);
-  Node* TailCallN(CallDescriptor* descriptor, Node* code_target, Node** args);
-
+  CodeStubAssembler(Isolate* isolate, Zone* zone,
+                    CallDescriptor* call_descriptor, Code::Flags flags,
+                    const char* name);
   Node* SmiShiftBitsConstant();
 
   base::SmartPointer<RawMachineAssembler> raw_assembler_;
   Code::Flags flags_;
   const char* name_;
   bool code_generated_;
   ZoneVector<Variable::Impl*> variables_;
 
   DISALLOW_COPY_AND_ASSIGN(CodeStubAssembler);
 };
@@ skipping 23 matching lines @@
   // Map of variables to the list of value nodes that have been added from each
   // merge path in their order of merging.
   std::map<Variable::Impl*, std::vector<Node*>> variable_merges_;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_CODE_STUB_ASSEMBLER_H_