Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1674613002: Don't expose private libraries with dart.library.X. (Closed)

Created:
4 years, 10 months ago by floitsch
Modified:
4 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, rmacnak
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove debug print. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +5 lines, -1 line 0 comments Download
M tests/language/library_env_test.dart View 1 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
4 years, 10 months ago (2016-02-05 12:36:12 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1674613002/diff/1/tests/language/library_env_test.dart File tests/language/library_env_test.dart (right): https://codereview.chromium.org/1674613002/diff/1/tests/language/library_env_test.dart#newcode18 tests/language/library_env_test.dart:18: print(const bool.fromEnvironment("dart.library._internal")); Remove debug print?
4 years, 10 months ago (2016-02-05 12:59:40 UTC) #3
floitsch
Committed patchset #2 (id:20001) manually as a9b8efcd0ddfec223c5aeac7b8b85af0459e1754 (presubmit successful).
4 years, 10 months ago (2016-02-05 16:36:21 UTC) #5
floitsch
4 years, 10 months ago (2016-02-05 16:36:43 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1674613002/diff/1/tests/language/library_env_...
File tests/language/library_env_test.dart (right):

https://codereview.chromium.org/1674613002/diff/1/tests/language/library_env_...
tests/language/library_env_test.dart:18: print(const
bool.fromEnvironment("dart.library._internal"));
On 2016/02/05 12:59:39, Johnni Winther wrote:
> Remove debug print?

Done.

Powered by Google App Engine
This is Rietveld 408576698