extensions/common/mojo/wifi_display_session_service.mojom - Issue 1674583002: [chrome.displaySource] Session notification improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/mojo/wifi_display_session_service.mojom

Issue 1674583002: [chrome.displaySource] Session notification improvements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from Antony Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/display_source.idl ('k') | extensions/renderer/api/display_source/wifi_display/wifi_display_session.h » ('j') | extensions/renderer/display_source_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/mojo/wifi_display_session_service.mojom

diff --git a/extensions/common/mojo/wifi_display_session_service.mojom b/extensions/common/mojo/wifi_display_session_service.mojom

index e30225677dee67d48f78568f1da088b0c583e15f..637a1f0580f52641d653411a7be01d672d201b67 100644

--- a/extensions/common/mojo/wifi_display_session_service.mojom

+++ b/extensions/common/mojo/wifi_display_session_service.mojom

@@ -21,13 +21,13 @@ interface WiFiDisplaySessionService {

interface WiFiDisplaySessionServiceClient {

// Notification of a successfull connection to a sink.

- OnConnected(int32 sink_id, string ip_address);

+ OnEstablished(string ip_address);

- // Notification of a connection termination.

- OnDisconnected(int32 sink_id);

+ // Notification of a session termination.

+ OnTerminated();

// Notification of an error occurred during the session.

- OnError(int32 sink_id, int32 type, string description);

+ OnError(int32 type, string description);

shalamov 2016/02/11 08:56:24 type => enum that matches idl?

// Invoked to transmit a controlling message from

// the connected sink.