Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 16745008: chrome://restart implemented. (Closed)

Created:
7 years, 6 months ago by scheib
Modified:
4 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

chrome://restart implemented. To assist in manual testing, chrome://restart provides a convenient mechanism to cause a restart on demand. BUG=248210 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209553

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : text_area_ is designed to teardown first. #

Patch Set 4 : PostTask to AttemptRestart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/browser_about_handler.cc View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 31 (0 generated)
scheib
7 years, 6 months ago (2013-06-10 18:26:24 UTC) #1
jam
How important/needed is this? we haven't needed it in 6 years, so I'm inclined to ...
7 years, 6 months ago (2013-06-10 23:28:06 UTC) #2
scheib
It is coming up in packaged apps development, where many applications and or the system ...
7 years, 6 months ago (2013-06-10 23:57:34 UTC) #3
jam
On 2013/06/10 23:57:34, scheib wrote: > It is coming up in packaged apps development, where ...
7 years, 6 months ago (2013-06-11 20:33:37 UTC) #4
scheib
jam, thanks, responses below & you're no longer needed for owners coverage. sky, would you ...
7 years, 6 months ago (2013-06-14 22:15:40 UTC) #5
jam
On 2013/06/14 22:15:40, scheib wrote: > jam, thanks, responses below & you're no longer needed ...
7 years, 6 months ago (2013-06-14 22:57:58 UTC) #6
scheib
On Fri, Jun 14, 2013 at 3:57 PM, <jam@chromium.org> wrote: > On 2013/06/14 22:15:40, scheib ...
7 years, 6 months ago (2013-06-14 23:34:21 UTC) #7
jam
On 2013/06/14 23:34:21, scheib wrote: > On Fri, Jun 14, 2013 at 3:57 PM, <mailto:jam@chromium.org> ...
7 years, 6 months ago (2013-06-15 00:07:01 UTC) #8
sky
https://codereview.chromium.org/16745008/diff/15001/chrome/browser/lifetime/application_lifetime.cc File chrome/browser/lifetime/application_lifetime.cc (right): https://codereview.chromium.org/16745008/diff/15001/chrome/browser/lifetime/application_lifetime.cc#newcode180 chrome/browser/lifetime/application_lifetime.cc:180: static bool restart_already_requested = false; Why do we need ...
7 years, 6 months ago (2013-06-17 14:55:27 UTC) #9
scheib
Thanks sky: https://codereview.chromium.org/16745008/diff/15001/chrome/browser/lifetime/application_lifetime.cc File chrome/browser/lifetime/application_lifetime.cc (right): https://codereview.chromium.org/16745008/diff/15001/chrome/browser/lifetime/application_lifetime.cc#newcode180 chrome/browser/lifetime/application_lifetime.cc:180: static bool restart_already_requested = false; On 2013/06/17 ...
7 years, 6 months ago (2013-06-17 15:34:23 UTC) #10
sky1
Where is the crash? AFAICT it is fine to invoke AttemptRestart more than once. On ...
7 years, 6 months ago (2013-06-17 16:38:16 UTC) #11
scheib
On Mon, Jun 17, 2013 at 9:38 AM, Scott Violet <sky@google.com> wrote: > Where is ...
7 years, 6 months ago (2013-06-17 17:14:27 UTC) #12
scheib
bump.
7 years, 6 months ago (2013-06-19 22:50:15 UTC) #13
sky1
Did you resolve the AttemptRestart() issue? As I said, adding a static boolean to make ...
7 years, 6 months ago (2013-06-19 22:59:43 UTC) #14
scheib
sky, PTAL. Removed static limiting to just one AttemptRestart. Adjusted to handle OmniboxViewGtk::text_view_ being null, ...
7 years, 5 months ago (2013-06-26 23:28:19 UTC) #15
sky
+estade I'm a bit nervous about adding a conditional to the gtk omnibox code. What ...
7 years, 5 months ago (2013-06-26 23:59:51 UTC) #16
scheib
I don't know the root cause. It did not trigger when I plumbed the restart ...
7 years, 5 months ago (2013-06-27 00:36:29 UTC) #17
Evan Stade
the other option is to change text_view_ to an OwnedWidgetGtk
7 years, 5 months ago (2013-06-27 18:08:39 UTC) #18
scheib
On 2013/06/27 18:08:39, Evan Stade wrote: > the other option is to change text_view_ to ...
7 years, 5 months ago (2013-06-27 19:27:08 UTC) #19
Evan Stade
I'm not really certain of the best fix. If |text_view_| has been destroyed it's probably ...
7 years, 5 months ago (2013-06-27 19:30:32 UTC) #20
scheib
sky, ptal. Deferring AttemptRestart with a PostTask removes the problem of gtk objects being destroyed ...
7 years, 5 months ago (2013-07-01 21:13:43 UTC) #21
sky
LGTM
7 years, 5 months ago (2013-07-01 21:21:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/16745008/52001
7 years, 5 months ago (2013-07-01 21:27:08 UTC) #23
commit-bot: I haz the power
Change committed as 209553
7 years, 5 months ago (2013-07-02 00:14:17 UTC) #24
sanna101010
lgtm
6 years, 4 months ago (2014-07-27 19:55:28 UTC) #25
sanna101010
lgtm
6 years, 4 months ago (2014-07-27 19:55:30 UTC) #26
sanna101010
Sos
6 years, 4 months ago (2014-07-27 20:00:17 UTC) #27
sanna101010
Sos
6 years, 4 months ago (2014-07-27 20:02:17 UTC) #28
sanna101010
lgtm You hackad my café and not er se wh att i cancer som
6 years, 4 months ago (2014-08-07 21:21:15 UTC) #29
kristy.kstewart.stewart585
On 2014/08/07 21:21:15, sanna101010 wrote: > lgtm > > You hackad my café and not ...
4 years, 4 months ago (2016-08-09 03:53:43 UTC) #30
kristy.kstewart.stewart585
4 years, 4 months ago (2016-08-09 04:00:59 UTC) #31
Message was sent while issue was closed.
On 2016/08/09 03:53:43, kristy.kstewart.stewart585 wrote:
> On 2014/08/07 21:21:15, sanna101010 wrote:
> > lgtm
> > 
> > You hackad my café and not er se wh att i cancer som

Powered by Google App Engine
This is Rietveld 408576698