runtime/vm/flow_graph_optimizer.cc - Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index b37b654e9206d25da89e68caad4b76648ce0cc95..594a9c068d1384edace34f41b4918a6e25856367 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -3885,6 +3885,7 @@ RawBool* FlowGraphOptimizer::InstanceOfAsBool(

type_class,

TypeArguments::Handle(Z),

NULL,

+ NULL,

Heap::kOld);

results->Add(cls.id());

results->Add(is_subtype);

@@ -3979,6 +3980,7 @@ static bool TryExpandTestCidsResult(ZoneGrowableArray<intptr_t>* results,

type_class,

TypeArguments::Handle(),

NULL,

+ NULL,

Heap::kOld);

results->Add((*results)[results->length() - 2]);

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »