runtime/vm/code_generator.cc - Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator.cc

Issue 1674383002: Keep a trail while checking upper bounds in the VM in order to properly handle (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator.cc

diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc

index 24c8c8cd26d05ba62af8848128b1b317f629c828..a45853dc8887a6503f01866ecbd55b88ffcb2293 100644

--- a/runtime/vm/code_generator.cc

+++ b/runtime/vm/code_generator.cc

@@ -205,7 +205,8 @@ DEFINE_RUNTIME_ENTRY(InstantiateType, 2) {

ASSERT(!type.IsNull() && !type.IsInstantiated());

ASSERT(instantiator.IsNull() || instantiator.IsInstantiated());

Error& bound_error = Error::Handle();

- type = type.InstantiateFrom(instantiator, &bound_error, NULL, Heap::kOld);

+ type =

+ type.InstantiateFrom(instantiator, &bound_error, NULL, NULL, Heap::kOld);

if (!bound_error.IsNull()) {

// Throw a dynamic type error.

const TokenPosition location = GetCallerLocation();

« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »