Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
167433002:
ARM Skia NEON patches - 20bis - BitmapProcState accurracy (Closed)
|
Created:
6 years, 10 months ago by kevin.petit Modified:
6 years, 10 months ago CC:
skia-review_googlegroups.com Base URL:
https://skia.googlesource.com/skia.git@master Visibility:
Public. |
DescriptionARM Skia NEON patches - 20bis - BitmapProcState accurracy
Use SkFractionalInt for some calculations to improve accuracy.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>;
BUG=skia:2175
NOTRY=true
Committed: http://code.google.com/p/skia/source/detail?r=13518
Patch Set 1 #Patch Set 2 : Add ignored-tests.txt #Patch Set 3 : Rebase #
Messages
Total messages: 24 (0 generated)
drive-by: LGTM because I have verified that this fixes the problem on an ARM device
Given the number of rebaselines, I'd prefer to coordinate with you before committing this one. Let me know when you think the tree is ready to welcome this patch.
lgtm. Kevin feel free to submit when you get in tomorrow so that you can rebaseline. There are some current rebaselines going on for other parts of the project, but none of them are currently affecting android.
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/167433002/10002
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools http://108.170.219.164:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Re...
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/167433002/10002
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools http://108.170.219.164:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Re...
The CQ bit was checked by kevin.petit@arm.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/167433002/240001
On 2014/02/20 10:31:19, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://skia-tree-status.appspot.com/cq/kevin.petit%40arm.com/167433002/240001 Build-Mac10.7-Clang-x86-Release-Trybot doesn't seem to be very responsive, is there an issue?
On 2014/02/20 15:30:53, kevin.petit wrote: > On 2014/02/20 10:31:19, I haz the power (commit-bot) wrote: > > CQ is trying da patch. Follow status at > > https://skia-tree-status.appspot.com/cq/kevin.petit%2540arm.com/167433002/240001 > > Build-Mac10.7-Clang-x86-Release-Trybot doesn't seem to be very responsive, is > there an issue? It was out of commission until a few hours ago. It is back up now in a limited capacity and yoou can follow its progress here. http://108.170.219.164:10117/builders/Build-Mac10.7-Clang-x86-Release-Trybot
The CQ bit was unchecked by djsollen@google.com
The CQ bit was checked by djsollen@google.com
On 2014/02/20 17:08:58, djsollen wrote: > On 2014/02/20 15:30:53, kevin.petit wrote: > > On 2014/02/20 10:31:19, I haz the power (commit-bot) wrote: > > > CQ is trying da patch. Follow status at > > > > https://skia-tree-status.appspot.com/cq/kevin.petit%252540arm.com/167433002/2... > > > > Build-Mac10.7-Clang-x86-Release-Trybot doesn't seem to be very responsive, is > > there an issue? > > It was out of commission until a few hours ago. It is back up now in a limited > capacity and yoou can follow its progress here. > > http://108.170.219.164:10117/builders/Build-Mac10.7-Clang-x86-Release-Trybot Ok, thanks. Seeing the backlog, I think I'll be able to submit the rebaselines only tomorrow.
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/167433002/240001
Message was sent while issue was closed.
Change committed as 13518 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
