third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1674323002: Detect a change in border that affects a positioned object's height or position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1674323002: Detect a change in border that affects a positioned object's height or position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/block/positioning/positioned-container-changes-block-direction-border-with-positioned-descendant.html ('K') | « third_party/WebKit/LayoutTests/fast/block/positioning/positioned-container-changes-block-direction-border-with-positioned-descendant-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 77b763034f64a4c08d3b78b1202a49479cebcd05..dc44d453e21cef580b2f5ed2930f84dd10054bca 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -491,6 +491,7 @@ protected:

unsigned m_hasPositionedObjects : 1;

unsigned m_hasPercentHeightDescendants : 1;

+ mutable unsigned m_heightAvailableToChildrenChanged : 1;

mstensho (USE GERRIT) 2016/02/17 10:19:42 Please put this next to m_widthAvailableToChildren

// LayoutRubyBase objects need to be able to split and merge, moving their children around

// (calling moveChildTo, moveAllChildrenTo, and makeChildrenNonInline).

friend class LayoutRubyBase;