third_party/WebKit/LayoutTests/fast/block/positioning/positioned-container-changes-block-direction-border-with-positioned-descendant.html - Issue 1674323002: Detect a change in border that affects a positioned object's height or position

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/positioning/positioned-container-changes-block-direction-border-with-positioned-descendant.html

Issue 1674323002: Detect a change in border that affects a positioned object's height or position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/block/positioning/positioned-container-changes-block-direction-border-with-positioned-descendant-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #container {

	4 position: relative;

	5 width: 500px;

	6 height: 500px;

	7 background: #C0C0C0;

	8 border-width: 150px 150px;
	mstensho (USE GERRIT) 2016/02/09 09:08:51 This has no effect with border-style being none, s This has no effect with border-style being none, so you can just remove the declaration.
	9 }

	10 #parent {

	11 position: absolute;

	12 top: 0;

	13 bottom: 0;

	14 left: 0;

	15 right: 0;

	16 border: 0px solid rgba(255, 255, 255, .5);

	17 border-width: 150px 150px;
	mstensho (USE GERRIT) 2016/02/09 09:08:51 This overrides the width set in the shorthand abov This overrides the width set in the shorthand above. Why not just "border: 150px solid rgba(...)"?
	18 }

	19 #parent div {
	mstensho (USE GERRIT) 2016/02/09 09:08:51 looks like #child to me. :) looks like #child to me. :)
	20 position: absolute;

	21 left: 1px;

	22 top: 1px;

	23 right: 1px;

	24 bottom: 1px;

	25 border: 1px solid #000;

	26 }

	27 </style>

	28 <script src="../../../resources/check-layout.js"></script>

	29 <p>crbug.com/581612: Changing block-direction border width on a positioned eleme nt with auto height should flex the height of its descendants.</p>
	mstensho (USE GERRIT) 2016/02/09 09:08:51 How about a human observable pass condition? There How about a human observable pass condition? There seems to be pretty borders and backgrounds here, so why not describe what we're expected to see? I like tests that say "There should be no red below", or "There should be a <your favorite color> square below", or something else that a human can use to easily determine that it's a pass or fail.
	30 <div id="console"></div>

	31 <div id="container">

	32 <div id="parent">

	33 <div id="child" data-expected-height=338></div>

	34 </div>

	35 </div>

	36 <script>

	37 document.body.offsetTop;

	38 document.getElementById('parent').style.borderTopWidth = '10px';

	39 checkLayout('#child', document.getElementById('console'));

	40 </script>

OLD	NEW