Issue 16743004: Updating docs for appendText and insertingAdjacentText to reflect implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16743004: Updating docs for appendText and insertingAdjacentText to reflect implementation. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updating docs for appendText and insertAdjacentText to reflect implementation. Basically insertAdjacentText is not standardized but is natively supported on IE, Chrome and Opera. Chrome inserts only a text node, but IE will create <br/> elements for line breaks (acts more like innerText, which we suppress). Alternatively, we skip the native implementation and always polyfill the API, though I'd be more inclined to omit it entirely. BUG=11180 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=23827

Patch Set 1 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -8 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 6 months ago (2013-06-10 19:39:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23827 (presubmit successful).

Expand Messages | Collapse Messages