third_party/WebKit/LayoutTests/fast/dom/HTMLCollection/HTMLCollection-namedItem-invalidate-no-crash.html - Issue 1674273004: Do not re-register cached id-name HTMLCollection at same invalidation type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLCollection/HTMLCollection-namedItem-invalidate-no-crash.html

Issue 1674273004: Do not re-register cached id-name HTMLCollection at same invalidation type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/HTMLCollection/HTMLCollection-namedItem-invalidate-no-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <pre id=p1></pre>

	8 <pre id=p1></pre>

	9 <pre id=p1></pre>

	10 <script>

	11 description("Invalidation of cached id-name collections must not crash.");

	12

	13 if (window.testRunner)

	14 testRunner.dumpAsText();

	15

	16 var is = window["p1"];

	17 var div = document.createElement('div');

	18 document.body.appendChild(div);

	19 div.appendChild(is[is.length - 2]);

	20 // Invalidate the underlying cache.

	21 is.namedItem("p1").remove();

	22 // Out of bounds index, updates the collection length.

	23 is.item(13);

	24 // Remove parent of collection member; must invalidate cached length.

	25 div.remove();

	26 // Force re-caching.

	27 is.namedItem("p1");

	28 </script>

	29 </body>

	30 </html>

OLD	NEW