Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 167423004: Add filler at the new space top when forcing scavenge. (Closed)

Created:
6 years, 10 months ago by Jarin
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add filler at the new space top when forcing scavenge. We only seem to force scavenge in our cctest test suite, so this is expected to fix some flakiness in our tests, but it will not improve stability of v8 itself. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19460

Patch Set 1 #

Patch Set 2 : Remove PerformScavenge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -40 lines) Patch
M src/heap.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/heap.cc View 1 3 chunks +16 lines, -21 lines 0 comments Download
M test/cctest/test-api.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 2 chunks +24 lines, -4 lines 1 comment Download
M test/cctest/test-symbols.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
6 years, 10 months ago (2014-02-18 07:05:43 UTC) #1
Hannes Payer (out of office)
I think the problem is the PerformScavenge call, which avoids the main gc selection logic ...
6 years, 10 months ago (2014-02-18 09:39:13 UTC) #2
Hannes Payer (out of office)
LGTM, one nit https://codereview.chromium.org/167423004/diff/50001/test/cctest/test-mementos.cc File test/cctest/test-mementos.cc (right): https://codereview.chromium.org/167423004/diff/50001/test/cctest/test-mementos.cc#newcode66 test/cctest/test-mementos.cc:66: heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask); Change it to CcTest::i_isolate()->heap()->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
6 years, 10 months ago (2014-02-18 11:41:03 UTC) #3
Jarin
6 years, 10 months ago (2014-02-18 16:35:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698