Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 16741002: Skip some conditional deopts for Div/Mul when all uses are truncating (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Skip some conditional deopts for Div/Mul when all uses are truncating. - set "can be minus zero" flag properly so minus-zero checks are skipped - skip "integer result?" check in division code when uses are truncating - drive-by cleanup: consolidated computation of kCanOverflow flag for Add/Sub into range inference phase BUG=v8:2132 R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15060

Patch Set 1 : #

Patch Set 2 : added regression test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -79 lines) Patch
M src/arm/lithium-codegen-arm.cc View 4 chunks +31 lines, -17 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +8 lines, -4 lines 1 comment Download
M src/hydrogen-instructions.cc View 9 chunks +39 lines, -28 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +27 lines, -11 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +26 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-2132.js View 1 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 6 months ago (2013-06-10 15:00:52 UTC) #1
Sven Panne
LGTM in the sense that it will probably work. Nevertheless, I don't like the current ...
7 years, 6 months ago (2013-06-11 07:59:29 UTC) #2
Jakob Kummerow
7 years, 6 months ago (2013-06-11 11:44:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15060 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698