Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1674063002: Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (Closed)

Created:
4 years, 10 months ago by apacible
Modified:
4 years, 10 months ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (patchset #9 id:440001 of https://codereview.chromium.org/1446623003/ ) Reason for revert: Flaky on Mac 10.9 again. See: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 Original issue's description: > [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. > > Currently only constrained web dialogs for views (Linux/Windows) are able to > autoresize. This change implements the option to pass in minimum and maximum > sizes and enabling autoresizing functionality for OSX. > > This change adds two static functions for options on whether to create a > ConstrainedWindowsMac that autoresizes or is of fixed size. > > The initial patch was reverted because of flaky tests in Mac 10.9. Upon further investigation, the ConstrainedWebDialogBrowserTest tests were also flaky on other Mac versions, such as 10.10. At the time, the test would fail once every 4-5,000 runs. After picking up this patch again, I was unable to repro the failing test after ~20,000 runs. > > The original patch can be found at: https://codereview.chromium.org/1430023002 > > BUG=217034 > > Committed: https://crrev.com/c47b9b44157a34aa5df0acebe357dc0164f49887 > Cr-Commit-Position: refs/heads/master@{#374039} TBR=thakis@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=217034 Committed: https://crrev.com/dc20e09b39b12af7642011c2d71d4fa70259d0c4 Cr-Commit-Position: refs/heads/master@{#374072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -319 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 8 chunks +18 lines, -139 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 4 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +8 lines, -42 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 6 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 7 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
apacible
Created Revert of [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
4 years, 10 months ago (2016-02-07 20:54:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674063002/1
4 years, 10 months ago (2016-02-07 20:54:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674063002/1
4 years, 10 months ago (2016-02-07 21:02:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674063002/1
4 years, 10 months ago (2016-02-07 21:32:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674063002/1
4 years, 10 months ago (2016-02-07 22:02:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674063002/1
4 years, 10 months ago (2016-02-07 22:32:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-07 22:55:22 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-07 22:56:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc20e09b39b12af7642011c2d71d4fa70259d0c4
Cr-Commit-Position: refs/heads/master@{#374072}

Powered by Google App Engine
This is Rietveld 408576698