Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1674053002: msan: build expat from source (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

msan: build expat from source This should let us test it on the MSAN bot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1674053002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Committed: https://skia.googlesource.com/skia/+/4e79f334525d722358adc62c0d0b14c38853812d

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Patch Set 4 : fixed? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -42 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A gyp/expat.gyp View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M gyp/ports.gyp View 1 2 3 1 chunk +4 lines, -10 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 2 3 2 chunks +1 line, -26 lines 0 comments Download
M tools/dm_flags.json View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M tools/dm_flags.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
mtklein
lgtm
4 years, 10 months ago (2016-02-07 20:25:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674053002/40001
4 years, 10 months ago (2016-02-07 20:25:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/5961)
4 years, 10 months ago (2016-02-07 20:26:23 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674053002/60001
4 years, 10 months ago (2016-02-07 20:40:16 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674053002/60001
4 years, 10 months ago (2016-02-07 20:45:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674053002/60001
4 years, 10 months ago (2016-02-07 20:45:52 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-07 21:31:27 UTC) #24
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4e79f334525d722358adc62c0d0b14c38853812d

Powered by Google App Engine
This is Rietveld 408576698