Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1674043002: Fix confusion between parameters vs arguments in parser. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix confusion between parameters vs arguments in parser. There are two changes: 1. Modify `_isPeekGenericTypeParametersAndOpenParen` to call `_skipTypeParameterList` instead of `_skipTypeArgumentList`. This fixes parsing of generic function declarations like `f<@a T>() {}`, which previously couldn't be parsed because `<@a T>` isn't a valid type argument list. 2. Rename `_isLikelyParameterList` to `_isLikelyArgumentList` to reflect how it is actually used (and what it actually does). This is no user-visible effect. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/079e8a1d6289730b62ec90337fa348a8bc1a9922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 7 chunks +8 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-07 15:58:42 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-07 16:25:24 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-07 18:42:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
079e8a1d6289730b62ec90337fa348a8bc1a9922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698