src/IceInstARM32.h - Issue 1674033002: Subzero: Clean up some uses of *_cast<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.h

Issue 1674033002: Subzero: Clean up some uses of *_cast<>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: More code review changes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.h

diff --git a/src/IceInstARM32.h b/src/IceInstARM32.h

index bce1aca787ddd3b6484855fc2e2be4a6a82ad9ad..2be562aaf5701f0d2c9a709a10b99c772eddc06b 100644

--- a/src/IceInstARM32.h

+++ b/src/IceInstARM32.h

@@ -348,7 +348,7 @@ public:

static StackVariable *create(Cfg *Func, Type Ty, SizeT Index) {

return new (Func->allocate<StackVariable>()) StackVariable(Ty, Index);

}

- const static OperandKind StackVariableKind =

+ constexpr static auto StackVariableKind =

static_cast<OperandKind>(kVariable_Target);

static bool classof(const Operand *Operand) {

return Operand->getKind() == StackVariableKind;

« no previous file with comments | « src/IceInst.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »