src/IceCfg.cpp - Issue 1674033002: Subzero: Clean up some uses of *_cast<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfg.cpp

Issue 1674033002: Subzero: Clean up some uses of *_cast<>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: More code review changes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfg.cpp

diff --git a/src/IceCfg.cpp b/src/IceCfg.cpp

index fe44ee73d456366a568faf58ca1d25a4f43625c0..6565667e7287f6c52b791f857732f3c91ba6d333 100644

--- a/src/IceCfg.cpp

+++ b/src/IceCfg.cpp

@@ -916,8 +916,7 @@ bool Cfg::validateLiveness() const {

// of the block, because a Phi temporary may be live at the end of

// the previous block, and if it is also assigned in the first

// instruction of this block, the adjacent live ranges get merged.

- if (static_cast<class Inst *>(&Instr) != FirstInst &&

- !Instr.isDestRedefined() &&

+ if (&Instr != FirstInst && !Instr.isDestRedefined() &&

Dest->getLiveRange().containsValue(InstNumber - 1, IsDest))

Invalid = true;

if (Invalid) {

« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceInst.cpp » ('j') | no next file with comments »