Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1674023003: Update tools/v8heapconst.py. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update tools/v8heapconst.py. R=jkummerow@chromium.org Committed: https://crrev.com/a13e0af5063c95a1281d254b3a97492352902957 Cr-Commit-Position: refs/heads/master@{#33803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -119 lines) Patch
M tools/v8heapconst.py View 7 chunks +116 lines, -119 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 10 months ago (2016-02-08 07:47:40 UTC) #1
Jakob Kummerow
rubberstamp LGTM
4 years, 10 months ago (2016-02-08 07:51:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674023003/1
4 years, 10 months ago (2016-02-08 07:51:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 08:14:18 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 08:15:00 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a13e0af5063c95a1281d254b3a97492352902957
Cr-Commit-Position: refs/heads/master@{#33803}

Powered by Google App Engine
This is Rietveld 408576698