Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1673933002: remove unused locals/members/test functions (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
Reviewers:
Bob Nystrom, Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove unused locals/members/test functions Some of these slipped in with the CL I just sent, a few others existed previously. I'd been sort of ignoring the hint window. R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/e3a6a5a0d9f015c7e7ebbf35ddf705af191249af

Patch Set 1 #

Patch Set 2 : rm newlines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/generated/shared_messages.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 4 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
4 years, 10 months ago (2016-02-05 23:28:34 UTC) #3
Bob Nystrom
LGTM. Deleted code is best code.
4 years, 10 months ago (2016-02-05 23:36:42 UTC) #4
Jennifer Messerly
Committed patchset #2 (id:20001) manually as e3a6a5a0d9f015c7e7ebbf35ddf705af191249af (presubmit successful).
4 years, 10 months ago (2016-02-05 23:40:35 UTC) #6
Paul Berry
4 years, 10 months ago (2016-02-07 13:52:37 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698