Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167393002: PPAPI: Always inform RenderViewImpl of instance deletion (Closed)

Created:
6 years, 10 months ago by dmichael (off chromium)
Modified:
6 years, 10 months ago
Reviewers:
teravest, nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

PPAPI: Always inform RenderViewImpl of instance deletion BUG=343576 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251810

Patch Set 1 #

Patch Set 2 : wrap this in base::Unretained #

Patch Set 3 : wrap this in base::Unretained #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dmichael (off chromium)
teravest: For OWNERS nasko: to look at the comment Turns out I didn't have to ...
6 years, 10 months ago (2014-02-14 18:53:15 UTC) #1
nasko
LGTM
6 years, 10 months ago (2014-02-14 18:55:27 UTC) #2
teravest
lgtm
6 years, 10 months ago (2014-02-14 19:24:26 UTC) #3
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 10 months ago (2014-02-14 19:26:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/167393002/90001
6 years, 10 months ago (2014-02-14 19:28:15 UTC) #5
dmichael (off chromium)
6 years, 10 months ago (2014-02-14 20:37:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 21:32:07 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264569
6 years, 10 months ago (2014-02-14 21:32:07 UTC) #8
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 10 months ago (2014-02-18 18:21:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/167393002/90001
6 years, 10 months ago (2014-02-18 18:27:39 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:08:15 UTC) #11
Message was sent while issue was closed. 
Change committed as 251810

Powered by Google App Engine
This is Rietveld 408576698