Issue 1673913002: Separate CONSTANT_EXPRESSION_RESOLVED flag from RESOLVED_UNITx.

Issue 1673913002: Separate CONSTANT_EXPRESSION_RESOLVED flag from RESOLVED_UNITx. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Separate CONSTANT_EXPRESSION_RESOLVED flag from RESOLVED_UNITx. We only need to know that we can eveluate the constant. In non-summaries world we have the resolved unit anyway. But in case of summaries we don't, but we know that all the constant expressions are resynthesized as resolved (even if lazily). R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/010e0e6b71364c80ae02549fa3a23c1946e8b0ba

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -38 lines)			Patch
M	pkg/analyzer/lib/src/generated/constant.dart	View	6 chunks	+7 lines, -15 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	3 chunks	+71 lines, -23 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 010e0e6b71364c80ae02549fa3a23c1946e8b0ba (presubmit successful).

4 years, 10 months ago (2016-02-06 02:04:29 UTC) #4

Message was sent while issue was closed.

lgtm