Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 16739008: For-of statements do not permit initializers. (Closed)

Created:
7 years, 6 months ago by wingo
Modified:
7 years, 6 months ago
CC:
v8-dev, arv (Not doing code reviews)
Visibility:
Public.

Description

For-of statements do not permit initializers. R=rossberg@chromium.org BUG=v8:2720 Committed: http://code.google.com/p/v8/source/detail?r=15082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M src/preparser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/harmony/iteration-syntax.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wingo
This CL depends on the for-in crasher fix, FWIW.
7 years, 6 months ago (2013-06-10 16:52:26 UTC) #1
rossberg
LGTM Please wait with landing until we have pushed to trunk today.
7 years, 6 months ago (2013-06-11 11:43:17 UTC) #2
wingo
7 years, 6 months ago (2013-06-12 12:37:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698