improve debugging of strong mode checker/inference tests

improve debugging of strong mode checker/inference tests

Refactored along the lines of a previous discussion (https://codereview.chromium.org/1632113002/) ... I wasn't able to go all the way to reflective tests in the budget of time/automated refactoring, but I was able to make most of the improvements.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/c5f6ab52c85fcb86dae401452e8e3ae1f670db3e

[Jennifer Messerly, 2016-02-05 22:36:17]

Description was changed from

==========
improve debugging of strong mode checker/inference tests
==========

to

==========
improve debugging of strong mode checker/inference tests

Refactored along the lines of a previous discussion
(https://codereview.chromium.org/1632113002/) ... I wasn't able to go all the
way to reflective tests in the budget of time/automated refactoring, but I was
able to make most of the improvements.
==========

[Jennifer Messerly, 2016-02-05 22:37:51]

jmesserly@google.com changed reviewers:
+ paulberry@google.com, rnystrom@google.com

[Jennifer Messerly, 2016-02-05 22:37:52]

BTW, at some point a bad merge led to a test loss (for the JS builtin). I'm
going to investigate that separately after this one lands. I wanted to keep test
changes to a minimum. (basically just undoing some obsolete string
interpolation.)

[Jennifer Messerly, 2016-02-05 22:39:05]

On 2016/02/05 22:37:52, John Messerly wrote:
> BTW, at some point a bad merge led to a test loss (for the JS builtin). I'm
> going to investigate that separately after this one lands. I wanted to keep
test
> changes to a minimum. (basically just undoing some obsolete string
> interpolation.)

Also -- I got pretty close to reflective tests, but what happened was the groups
aren't very well organized right now, with a big mix of group & non-group tests.
Maybe something to revisit at some point in the future.

[Bob Nystrom, 2016-02-05 22:54:39]

LGTM!

https://codereview.chromium.org/1673843003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/strong_test_helper.dart (right):

https://codereview.chromium.org/1673843003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/strong_test_helper.dart:50: void
checkFiles(Map<String, String> files) {
Does this have any uses? If not, may as well leave it out for now.

https://codereview.chromium.org/1673843003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/strong_test_helper.dart:508: /// are defined
for: severe, error, warning, or info. Returns null if the level
Long lines.

[Jennifer Messerly, 2016-02-05 23:22:19]

Thanks!

https://codereview.chromium.org/1673843003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/strong_test_helper.dart (right):

https://codereview.chromium.org/1673843003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/strong_test_helper.dart:50: void
checkFiles(Map<String, String> files) {
On 2016/02/05 22:54:39, Bob Nystrom wrote:
> Does this have any uses? If not, may as well leave it out for now.

Good catch. Removed!

https://codereview.chromium.org/1673843003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/strong_test_helper.dart:508: /// are defined
for: severe, error, warning, or info. Returns null if the level
On 2016/02/05 22:54:39, Bob Nystrom wrote:
> Long lines.

Fixed.

[Jennifer Messerly, 2016-02-05 23:22:39]

Description was changed from

==========
improve debugging of strong mode checker/inference tests

Refactored along the lines of a previous discussion
(https://codereview.chromium.org/1632113002/) ... I wasn't able to go all the
way to reflective tests in the budget of time/automated refactoring, but I was
able to make most of the improvements.
==========

to

==========
improve debugging of strong mode checker/inference tests

Refactored along the lines of a previous discussion
(https://codereview.chromium.org/1632113002/) ... I wasn't able to go all the
way to reflective tests in the budget of time/automated refactoring, but I was
able to make most of the improvements.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5f6ab52c85fcb86dae401452e8e3ae1f670db3e
==========

[Jennifer Messerly, 2016-02-05 23:22:40]

Committed patchset #2 (id:20001) manually as
c5f6ab52c85fcb86dae401452e8e3ae1f670db3e (presubmit successful).

[Paul Berry, 2016-02-07 13:55:35]

lgtm