Add functions for autocomplete, selectionRange, directioinForFormData for TextArea element.

Add functions for autocomplete, selectionRange, directioinForFormData for TextArea element.

R=isherman@chromium.org, tkent@chromium.org
BUG=332557
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167347

[ziran.sun, 2014-02-14 18:53:02]

Please review with together with 

https://codereview.chromium.org/133443011/
https://codereview.chromium.org/140093005/

140093005 calls functions introduced by this patch. If I understand correctly,
landing sequence is 

this patch -> 140093005 -> 133443011(see blink roll delay comment by tkent)

Thanks!

[Ilya Sherman, 2014-02-14 21:40:46]

LGTM, though I think you might want to also include "virtual void
textFieldDidChange()" with a default implementation as part of this CL.  That
way you can immediately OVERRIDE it in 140093005, without which you might get
compile warnings.

[jamesr, 2014-02-14 23:59:18]

On 2014/02/14 21:40:46, Ilya Sherman wrote:
> LGTM, though I think you might want to also include "virtual void
> textFieldDidChange()" with a default implementation as part of this CL.  That
> way you can immediately OVERRIDE it in 140093005, without which you might get
> compile warnings.

I don't know what your suggestion means exactly, but cross-repository OVERRIDEs
are a terrible idea.

[tkent, 2014-02-16 23:56:05]

https://codereview.chromium.org/167383002/diff/1/Source/core/html/HTMLTextAre...
File Source/core/html/HTMLTextAreaElement.cpp (right):

https://codereview.chromium.org/167383002/diff/1/Source/core/html/HTMLTextAre...
Source/core/html/HTMLTextAreaElement.cpp:101: bool
HTMLTextAreaElement::shouldAutocomplete() const
This function adds nothing. We don't need to add  it.

[ziran.sun, 2014-02-17 10:40:19]

On 2014/02/16 23:56:05, tkent wrote:
>
https://codereview.chromium.org/167383002/diff/1/Source/core/html/HTMLTextAre...
> File Source/core/html/HTMLTextAreaElement.cpp (right):
> 
>
https://codereview.chromium.org/167383002/diff/1/Source/core/html/HTMLTextAre...
> Source/core/html/HTMLTextAreaElement.cpp:101: bool
> HTMLTextAreaElement::shouldAutocomplete() const
> This function adds nothing. We don't need to add  it.

shouldAutocomplete() is protected, we need to wrap it in HTMLTextAreaElement,
right?

[tkent, 2014-02-17 23:16:01]

On 2014/02/17 10:40:19, ziran.sun wrote:
> shouldAutocomplete() is protected, we need to wrap it in HTMLTextAreaElement,
> right?

I see.  Then, making shouldAutocomplete() public is a simpler solution.

[ziran.sun, 2014-02-18 12:06:28]

On 2014/02/17 23:16:01, tkent wrote:
> On 2014/02/17 10:40:19, ziran.sun wrote:
> > shouldAutocomplete() is protected, we need to wrap it in
HTMLTextAreaElement,
> > right?
> 
> I see.  Then, making shouldAutocomplete() public is a simpler solution.

Done

[tkent, 2014-02-18 13:04:00]

lgtm

[commit-bot: I haz the power, 2014-02-18 13:04:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/167383002/130001

[commit-bot: I haz the power, 2014-02-18 15:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-18 15:13:27]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[tkent, 2014-02-18 15:19:53]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-02-18 15:20:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/167383002/130001

[commit-bot: I haz the power, 2014-02-18 17:07:00]

Change committed as 167347