Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: cc/surfaces/surface_aggregator.cc

Issue 1673783004: Hook up BeginFrameSource to SurfaceFactoryClient via SurfaceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Now with unittests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_aggregator.cc
diff --git a/cc/surfaces/surface_aggregator.cc b/cc/surfaces/surface_aggregator.cc
index 0ef30d8f9db086c6bd447ae8eae7bca19a5df66e..667f7a63b9669157ec1c596619dffe9c712b11fb 100644
--- a/cc/surfaces/surface_aggregator.cc
+++ b/cc/surfaces/surface_aggregator.cc
@@ -42,12 +42,10 @@ void MoveMatchingRequests(
} // namespace
-SurfaceAggregator::SurfaceAggregator(SurfaceAggregatorClient* client,
- SurfaceManager* manager,
+SurfaceAggregator::SurfaceAggregator(SurfaceManager* manager,
ResourceProvider* provider,
bool aggregate_only_damaged)
- : client_(client),
- manager_(manager),
+ : manager_(manager),
provider_(provider),
next_render_pass_id_(1),
aggregate_only_damaged_(aggregate_only_damaged) {
@@ -478,19 +476,9 @@ void SurfaceAggregator::ProcessAddedAndRemovedSurfaces() {
Surface* surface_ptr = manager_->GetSurfaceForId(surface.first);
if (surface_ptr) {
surface_ptr->RunDrawCallbacks(SurfaceDrawStatus::DRAW_SKIPPED);
- client_->RemoveSurface(surface_ptr);
}
}
}
-
- for (const auto& surface : contained_surfaces_) {
- if (!previous_contained_surfaces_.count(surface.first)) {
- // Notify client of added surface.
- Surface* surface_ptr = manager_->GetSurfaceForId(surface.first);
- if (surface_ptr)
- client_->AddSurface(surface_ptr);
- }
- }
}
// Walk the Surface tree from surface_id. Validate the resources of the current

Powered by Google App Engine
This is Rietveld 408576698