Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4067)

Unified Diff: cc/surfaces/display.cc

Issue 1673783004: Hook up BeginFrameSource to SurfaceFactoryClient via SurfaceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Now with unittests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/display.cc
diff --git a/cc/surfaces/display.cc b/cc/surfaces/display.cc
index c0a8bde00090c5d9f1ccf102e1ae098c77869cab..37741bb2f6745c2d1a0fab87c688dcb128e3e7bb 100644
--- a/cc/surfaces/display.cc
+++ b/cc/surfaces/display.cc
@@ -52,10 +52,16 @@ Display::~Display() {
surface->RunDrawCallbacks(SurfaceDrawStatus::DRAW_SKIPPED);
}
}
+ // TODO(enne): unregister begin frame source
+ // manager_->SetBeginFrameSourceForNamespace(display_client_namespace,
+ // nullptr);
}
bool Display::Initialize(scoped_ptr<OutputSurface> output_surface,
DisplayScheduler* scheduler) {
+ // TODO(enne): Register begin frame source (maybe have DisplayClient do this?)
+ // manager_->SetBeginFrameSourceForNamespace(display_client_namespace,
+ // scheduler_->begin_frame_source_for_children());
output_surface_ = std::move(output_surface);
scheduler_ = scheduler;
return output_surface_->BindToClient(this);
@@ -134,8 +140,8 @@ void Display::InitializeRenderer() {
// overlays.
bool output_partial_list = renderer_->Capabilities().using_partial_swap &&
!output_surface_->GetOverlayCandidateValidator();
- aggregator_.reset(new SurfaceAggregator(
- this, manager_, resource_provider_.get(), output_partial_list));
+ aggregator_.reset(new SurfaceAggregator(manager_, resource_provider_.get(),
+ output_partial_list));
}
void Display::DidLoseOutputSurface() {
@@ -153,31 +159,6 @@ void Display::UpdateRootSurfaceResourcesLocked() {
scheduler_->SetRootSurfaceResourcesLocked(root_surface_resources_locked);
}
-void Display::AddSurface(Surface* surface) {
- // Checking for the output_surface ensures Display::Initialize has been
- // called and that scheduler_ won't change its value.
- DCHECK(output_surface_);
-
- // WebView's HardwareRenderer will never have a scheduler.
- if (!scheduler_)
- return;
-
- surface->AddBeginFrameSource(scheduler_->begin_frame_source_for_children());
-}
-
-void Display::RemoveSurface(Surface* surface) {
- // Checking for the output_surface ensures Display::Initialize has been
- // called and that scheduler_ won't change its value.
- DCHECK(output_surface_);
-
- // WebView's HardwareRenderer will never have a scheduler.
- if (!scheduler_)
- return;
-
- surface->RemoveBeginFrameSource(
- scheduler_->begin_frame_source_for_children());
-}
-
bool Display::DrawAndSwap() {
TRACE_EVENT0("cc", "Display::DrawAndSwap");

Powered by Google App Engine
This is Rietveld 408576698