components/mus/ws/window_finder_unittest.cc - Issue 1673783004: Hook up BeginFrameSource to SurfaceFactoryClient via SurfaceManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/ws/window_finder_unittest.cc

Issue 1673783004: Hook up BeginFrameSource to SurfaceFactoryClient via SurfaceManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mus unit tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/ws/test_server_window_delegate.cc ('K') | « components/mus/ws/test_server_window_delegate.cc ('k') | components/mus/ws/window_tree_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/ws/window_finder_unittest.cc

diff --git a/components/mus/ws/window_finder_unittest.cc b/components/mus/ws/window_finder_unittest.cc

index f38d70812067b4b067c4ff560f674df93a7ef72e..2d4d42f4159ff8e32b0c8130fcfcbeb645910a57 100644

--- a/components/mus/ws/window_finder_unittest.cc

+++ b/components/mus/ws/window_finder_unittest.cc

@@ -27,7 +27,7 @@ TEST(WindowFinderTest, FindDeepestVisibleWindow) {

child1.SetVisible(true);

child1.SetBounds(gfx::Rect(10, 10, 20, 20));

- ServerWindow child2(&window_delegate, WindowId(1, 3));

+ ServerWindow child2(&window_delegate, WindowId(1, 4));

enne (OOO) 2016/03/02 22:04:40 I think WindowIds need to be unique? This failed b

sky 2016/03/02 23:45:34 Good fix. Window ids should definitely be uniqute.

root.Add(&child2);

EnableHitTest(&child2);

child2.SetVisible(true);