[spellcheck] Don't spellcheck in removed language.

[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
Committed: https://crrev.com/c22b0fff6ec19ed2dd7bd2aa21cee4f3c6d612f9
Cr-Commit-Position: refs/heads/master@{#374485}

[please use gerrit instead, 2016-02-05 23:38:33]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-02-05 23:47:54]

Description was changed from

==========
Remove spellcheck dictionaries that are not in accept languages.

BUG=584519
==========

to

==========
Remove spellcheck dictionaries that are not in accept languages.

If you remove from chrome://settings/languages a language that has "Use this
language for spellchecking" selected, then this language will continue to be
used for spellchecking. This patch fixes the issue by listening to changes in
accept languages and disabling spellcheck for any language that is no longer in
accept languages.

BUG=584519
==========

[please use gerrit instead, 2016-02-05 23:48:10]

Description was changed from

==========
Remove spellcheck dictionaries that are not in accept languages.

If you remove from chrome://settings/languages a language that has "Use this
language for spellchecking" selected, then this language will continue to be
used for spellchecking. This patch fixes the issue by listening to changes in
accept languages and disabling spellcheck for any language that is no longer in
accept languages.

BUG=584519
==========

to

==========
Remove spellcheck dictionaries that are not in accept languages.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

[please use gerrit instead, 2016-02-05 23:50:02]

Description was changed from

==========
Remove spellcheck dictionaries that are not in accept languages.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

to

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

[please use gerrit instead, 2016-02-05 23:50:14]

Description was changed from

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

to

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

[please use gerrit instead, 2016-02-05 23:50:33]

rouslan@chromium.org changed reviewers:
+ groby@chromium.org

[please use gerrit instead, 2016-02-05 23:50:34]

Rachel, PTAL.

[groby-ooo-7-16, 2016-02-09 02:51:33]

lgtm

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_service.cc (right):

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:346:
base::SplitString(prefs->GetString(prefs::kAcceptLanguages), ",",
Sigh. Why is this not a list? (Undirected grumbling. Not fixable in this CL)

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:354:
dictionaries_pref.Init(prefs::kSpellCheckDictionaries, prefs);
If dictionaries and accept_languages were ordered, we could set_difference - but
we can't order them, right?

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_service.h (right):

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.h:162: void
OnAcceptLanguagesChanged();
Do we have any listener for the on/off of the flag?

[please use gerrit instead, 2016-02-09 20:45:50]

sending to cq.

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_service.cc (right):

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:346:
base::SplitString(prefs->GetString(prefs::kAcceptLanguages), ",",
On 2016/02/09 02:51:33, groby wrote:
> Sigh. Why is this not a list? (Undirected grumbling. Not fixable in this CL)

Acknowledged.

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:354:
dictionaries_pref.Init(prefs::kSpellCheckDictionaries, prefs);
On 2016/02/09 02:51:33, groby wrote:
> If dictionaries and accept_languages were ordered, we could set_difference -
but
> we can't order them, right?

Right, we can't order them, because we want to preserve the order as set in
chrome://settings/languages.

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_service.h (right):

https://codereview.chromium.org/1673783003/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.h:162: void
OnAcceptLanguagesChanged();
On 2016/02/09 02:51:33, groby wrote:
> Do we have any listener for the on/off of the flag? 

Yes, it's hooked directly to InitForAllRenderers():

 pref_change_registrar_.Add(
      prefs::kEnableContinuousSpellcheck,
      base::Bind(&SpellcheckService::InitForAllRenderers,
                 base::Unretained(this)));

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/spe...

[please use gerrit instead, 2016-02-09 20:45:57]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-02-09 20:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673783003/20001

[commit-bot: I haz the power, 2016-02-09 21:54:32]

Description was changed from

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

to

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

[commit-bot: I haz the power, 2016-02-09 21:54:33]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-02-09 21:56:05]

Description was changed from

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519
==========

to

==========
[spellcheck] Don't spellcheck in removed language.

If you remove from chrome://settings/languages a language that has "Use
this language for spellchecking" selected, then this language will
continue to be used for spellchecking. This patch fixes the issue by
listening to changes in accept languages and disabling spellcheck for
any language that is no longer in accept languages.

BUG=584519

Committed: https://crrev.com/c22b0fff6ec19ed2dd7bd2aa21cee4f3c6d612f9
Cr-Commit-Position: refs/heads/master@{#374485}
==========

[commit-bot: I haz the power, 2016-02-09 21:56:06]

Patchset 1 (id:??) landed as
https://crrev.com/c22b0fff6ec19ed2dd7bd2aa21cee4f3c6d612f9
Cr-Commit-Position: refs/heads/master@{#374485}