Issue 167373004: Fix automatic toolchain when msvs-ninja in GYP_GENERATORS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167373004: Fix automatic toolchain when msvs-ninja in GYP_GENERATORS (Closed)

Created:
6 years, 10 months ago by scottmg

Modified:
6 years, 10 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix automatic toolchain when msvs-ninja in GYP_GENERATORS Previously, we checked that GYP_GENERATORS was "ninja", but this broke when using GYP_GENERATORS=ninja,msvs-ninja. As there are no other supported genearators than those two now, there's no need to check that we're using ninja at all, so just remove that branch of the if. BUG=323300 R=jschuh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251406

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	build/gyp_chromium	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

6 years, 10 months ago (2014-02-14 20:11:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r251406 (presubmit successful).

Expand Messages | Collapse Messages