Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: remoting/host/client_session.cc

Issue 1673723002: Use IpcVideoFrameCapturer on network thread instead of capturer thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/client_session.h ('k') | remoting/host/client_session_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/client_session.cc
diff --git a/remoting/host/client_session.cc b/remoting/host/client_session.cc
index e51db40730301249a0672dc9563234c48405660d..8aa6997acf7dbdca77edba60b5c63334cb388c37 100644
--- a/remoting/host/client_session.cc
+++ b/remoting/host/client_session.cc
@@ -18,11 +18,9 @@
#include "remoting/codec/audio_encoder_verbatim.h"
#include "remoting/host/audio_capturer.h"
#include "remoting/host/audio_pump.h"
-#include "remoting/host/desktop_capturer_proxy.h"
#include "remoting/host/desktop_environment.h"
#include "remoting/host/host_extension_session.h"
#include "remoting/host/input_injector.h"
-#include "remoting/host/mouse_cursor_monitor_proxy.h"
#include "remoting/host/mouse_shape_pump.h"
#include "remoting/host/screen_controls.h"
#include "remoting/host/screen_resolution.h"
@@ -65,11 +63,6 @@ scoped_ptr<AudioEncoder> CreateAudioEncoder(
ClientSession::ClientSession(
EventHandler* event_handler,
scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> input_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> video_capture_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> video_encode_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> network_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
scoped_ptr<protocol::ConnectionToClient> connection,
DesktopEnvironmentFactory* desktop_environment_factory,
const base::TimeDelta& max_duration,
@@ -87,11 +80,6 @@ ClientSession::ClientSession(
client_clipboard_factory_(clipboard_echo_filter_.client_filter()),
max_duration_(max_duration),
audio_task_runner_(audio_task_runner),
- input_task_runner_(input_task_runner),
- video_capture_task_runner_(video_capture_task_runner),
- video_encode_task_runner_(video_encode_task_runner),
- network_task_runner_(network_task_runner),
- ui_task_runner_(ui_task_runner),
pairing_registry_(pairing_registry),
is_authenticated_(false),
pause_video_(false),
@@ -455,21 +443,13 @@ void ClientSession::ResetVideoPipeline() {
return;
// Create MouseShapePump to send mouse cursor shape.
- // TODO(sergeyu): Move MouseCursorMonitorProxy creation to DesktopEnvironment.
- // When using IpcDesktopCapturer the capture thread is not useful.
mouse_shape_pump_.reset(
- new MouseShapePump(make_scoped_ptr(new MouseCursorMonitorProxy(
- video_capture_task_runner_,
- desktop_environment_->CreateMouseCursorMonitor())),
+ new MouseShapePump(desktop_environment_->CreateMouseCursorMonitor(),
connection_->client_stub()));
// Create a VideoStream to pump frames from the capturer to the client.
- // TODO(sergeyu): Move DesktopCapturerProxy creation to DesktopEnvironment.
- // When using IpcDesktopCapturer the capture thread is not useful.
- scoped_ptr<webrtc::DesktopCapturer> capturer_proxy(new DesktopCapturerProxy(
- video_capture_task_runner_, std::move(video_capturer)));
+ video_stream_ = connection_->StartVideoStream(std::move(video_capturer));
- video_stream_ = connection_->StartVideoStream(std::move(capturer_proxy));
video_stream_->SetSizeCallback(
base::Bind(&ClientSession::OnScreenSizeChanged, base::Unretained(this)));
« no previous file with comments | « remoting/host/client_session.h ('k') | remoting/host/client_session_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698