flags and hacks to get MSAN bot going

flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to SkCodec, and skips .wbmps, .pngs, and .bmps.  We're only seeing issues in colortables for .png and .bmp.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550, skia:4900
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673663002

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

TBR=msarett@google.com

Committed: https://skia.googlesource.com/skia/+/e721a8e883231af1878772ecd23be325113fcc48

[mtklein_C, 2016-02-05 15:20:43]

Description was changed from

==========
custom DM flags for MSAN bot

BUG=skia:
==========

to

==========
custom DM flags for MSAN bot

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-02-05 15:22:15]

Description was changed from

==========
custom DM flags for MSAN bot

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
custom DM flags for MSAN bot

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:
==========

[mtklein_C, 2016-02-05 15:22:39]

Description was changed from

==========
custom DM flags for MSAN bot

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:
==========

to

==========
custom DM flags for MSAN bot

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein_C, 2016-02-05 16:32:06]

Description was changed from

==========
custom DM flags for MSAN bot

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
custom DM flags for MSAN bot

BUG=skia:4550
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein_C, 2016-02-05 16:41:20]

Description was changed from

==========
custom DM flags for MSAN bot

BUG=skia:4550
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
custom DM flags for MSAN bot

BUG=skia:4550
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein_C, 2016-02-05 18:54:58]

Description was changed from

==========
custom DM flags for MSAN bot

BUG=skia:4550
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and similar for our SkWbmpCodec code, which appears to be our fault.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein_C, 2016-02-05 20:06:51]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and similar for our SkWbmpCodec code, which appears to be our fault.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs (really, looks like only Index8).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein_C, 2016-02-05 20:09:53]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[mtklein_C, 2016-02-05 20:09:53]

Not ready to land yet.

[mtklein_C, 2016-02-05 20:10:01]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs (really, looks like only Index8).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs (really, looks like only Index8).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

COMMIT=false
==========

[mtklein_C, 2016-02-05 20:59:09]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-02-05 20:59:09]

I think this run will be green.

[mtklein, 2016-02-05 21:02:47]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs (really, looks like only Index8).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

COMMIT=false
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs and .bmps (we're only seeing issues in
colortables for .png and .bmp).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

COMMIT=false
==========

[mtklein_C, 2016-02-05 21:22:14]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs and .bmps (we're only seeing issues in
colortables for .png and .bmp).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

COMMIT=false
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs and .bmps (we're only seeing issues in
colortables for .png and .bmp).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein_C, 2016-02-05 21:22:41]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, skips .wbmps and .pngs and .bmps (we're only seeing issues in
colortables for .png and .bmp).

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and skips .wbmps, .pngs, and .bmps.  We're only seeing issues in
colortables for .png and .bmp.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

[mtklein, 2016-02-05 21:49:55]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-02-05 21:49:56]

https://codereview.chromium.org/1673663002/diff/220001/src/codec/SkJpegCodec.cpp
File src/codec/SkJpegCodec.cpp (right):

https://codereview.chromium.org/1673663002/diff/220001/src/codec/SkJpegCodec....
src/codec/SkJpegCodec.cpp:417: SkASSERT(dstRowBytes >= srcRowBytes);
This assert is failing for me when I run Codec unit tests.
Does that make sense?

https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX...

[msarett, 2016-02-05 23:41:55]

https://codereview.chromium.org/1673663002/diff/220001/src/codec/SkJpegCodec.cpp
File src/codec/SkJpegCodec.cpp (right):

https://codereview.chromium.org/1673663002/diff/220001/src/codec/SkJpegCodec....
src/codec/SkJpegCodec.cpp:417: SkASSERT(dstRowBytes >= srcRowBytes);
On 2016/02/05 21:49:56, mtklein wrote:
> This assert is failing for me when I run Codec unit tests.
> Does that make sense?
> 
>
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX...

Yes it does make sense.  Sorry for encouraging this check.

The client can pass in 0 (or whatever they want) for dstRowBytes when count ==
1.

[mtklein_C, 2016-02-07 00:10:50]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-07 00:10:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673663002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673663002/240001

[mtklein_C, 2016-02-07 00:55:27]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and skips .wbmps, .pngs, and .bmps.  We're only seeing issues in
colortables for .png and .bmp.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and skips .wbmps, .pngs, and .bmps.  We're only seeing issues in
colortables for .png and .bmp.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

TBR=msarett@google.com
==========

[mtklein_C, 2016-02-07 00:55:31]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-02-07 00:55:33]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-02-07 00:55:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673663002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673663002/240001

[commit-bot: I haz the power, 2016-02-07 03:12:26]

Description was changed from

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and skips .wbmps, .pngs, and .bmps.  We're only seeing issues in
colortables for .png and .bmp.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

TBR=msarett@google.com
==========

to

==========
flags and hacks to get MSAN bot going

This disables a few tests in DM:
   - one BlurLargeImage GM maybe is really broken
   - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from
source, 
     so MSAN can't see into it.

This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to
SkCodec, and skips .wbmps, .pngs, and .bmps.  We're only seeing issues in
colortables for .png and .bmp.

I think I can probably back out disabling Codec and the RAW image decodes...
they should all be covered by the libjpeg stifles.
 
BUG=skia:4550,skia:4900
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot

TBR=msarett@google.com

Committed:
https://skia.googlesource.com/skia/+/e721a8e883231af1878772ecd23be325113fcc48
==========

[commit-bot: I haz the power, 2016-02-07 03:12:27]

Committed patchset #13 (id:240001) as
https://skia.googlesource.com/skia/+/e721a8e883231af1878772ecd23be325113fcc48