Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1673623002: Revert of PPC: Type Feedback Vector lives in the closure (Closed)

Created:
4 years, 10 months ago by mvstanton
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC: Type Feedback Vector lives in the closure (patchset #1 id:1 of https://codereview.chromium.org/1671553002/ ) Reason for revert: issues with chromium api natives, must revert for now, thanks. Original issue's description: > PPC: Type Feedback Vector lives in the closure > > Port bb31db3ad6de16f86a61f6c7bbfd3274e3d957b5 > > Original commit message: > (RELAND: the problem before was a missing write barrier for adding the code > entry to the new closure. It's been addressed with a new macro instruction > and test. The only change to this CL is the addition of two calls to > __ RecordWriteCodeEntryField() in the platform CompileLazy builtin.) > > We get less "pollution" of type feedback if we have one vector per native > context, rather than one for the whole system. This CL moves the vector > appropriately. > > We rely more heavily on the Optimized Code Map in the SharedFunctionInfo. The > vector actually lives in the first slot of the literals array (indeed there is > great commonality between those arrays, they can be thought of as the same > thing). So we make greater effort to ensure there is a valid literals array > after compilation. > > This meant, for performance reasons, that we needed to extend > FastNewClosureStub to support creating closures with literals. And ultimately, > it drove us to move the optimized code map lookup out of FastNewClosureStub > and into the compile lazy builtin. > > The heap change is trivial so I TBR Hannes for it... > Also, Yang has had a look at the debugger changes already and approved 'em. So he is TBR style too. > And Benedikt reviewed it as well. > > R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > > Committed: https://crrev.com/753ad25efa4790ea7c80aceecfa223c3436ca36f > Cr-Commit-Position: refs/heads/master@{#33753} TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/14fa68a30540c19f495e5094e90d5a799d7907d6 Cr-Commit-Position: refs/heads/master@{#33765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -142 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mvstanton
Created Revert of PPC: Type Feedback Vector lives in the closure
4 years, 10 months ago (2016-02-05 10:44:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673623002/1
4 years, 10 months ago (2016-02-05 10:44:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 10:44:45 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 10:45:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14fa68a30540c19f495e5094e90d5a799d7907d6
Cr-Commit-Position: refs/heads/master@{#33765}

Powered by Google App Engine
This is Rietveld 408576698